LSP not indexing new files

mike.bronner · April 23, 2021, 1:41pm

I have a LSP extension (WIP - GitHub - GeneaLabs/panic-nova-intelephense.novaextension) and have noticed that the LSP only indexes when the project is opened. Any files created after that are not indexed.

Is this something I need to trigger on my own in the LSP, or should that be handled by Nova? (And if I do need to trigger that, what is the best way to go about it?)

Thanks!

GwynethLlewelyn · April 24, 2021, 7:59pm

Oh. That’s indeed a very good question. Does it help if you restart the LSP? I’m just curious — I could try it out but I’m lazy lol

mike.bronner · April 24, 2021, 8:00pm

Yes, restarting the LSP does index the newly-created files. It just seems odd that it has to be restarted, instead of Nova just retriggering the indexing.

jrf · April 26, 2021, 8:21pm

Nova should be providing all the notifications the language server should need to track new files, but you have to be able to tap into the RPC communication to diagnose. Does you language server offer an RPC logging?

mike.bronner · April 26, 2021, 8:53pm

Hi @jrf, thanks for weighing in. I don’t believe that logging is turned on, or is externally configurable – it’s installed via NPM and per the author only has internal logging available to him.

Is there something I can look for in the NPM package to see if this can be hooked into?

jrf · April 26, 2021, 10:03pm

A truly generic solution would be to stick a proxy between Nova and the language server. Without googling anything first, I’d poke at haproxy or nginx at the tcp level, siphoning everything that goes through to a log file…

This looks interesting GitHub - tomusdrw/jsonrpc-proxy: A generic and extensible JSON-RPC proxy, supporting cache and load-balancing. and learning a bit of Rust is kind of on my language bucket list.

I’d be shocked if Nova didn’t have the facility to log it all buried in there somewhere, though maybe not in release builds, and certainly not documented.

apexskier · May 6, 2021, 5:56pm

For the TypeScript extension I’ve used a simple shell script and tee to see what’s being sent back and forth. It doesn’t always work but might be a starting place.

github.com

apexskier/nova-typescript/blob/3ba2b96ba1eb90d43cf6959a92d7e870d34cc274/src/main.ts#L130


      
              p.onDidExit((status) => (status === 0 ? resolve() : reject()));
              p.start();
            });
            console.log("logging to", logDir);
            // passing inLog breaks some requests for an unknown reason
            // const inLog = nova.path.join(logDir, "languageServer-in.log");
            const outLog = nova.path.join(logDir, "languageServer-out.log");
            serviceArgs = {
              path: "/usr/bin/env",
              // args: ["bash", "-c", `tee "${inLog}" | "${runFile}" | tee "${outLog}"`],
              args: ["bash", "-c", `"${runFile}" | tee "${outLog}"`],
            };
          } else {
            serviceArgs = {
              path: runFile,
            };
          }
          
          const syntaxes = ["typescript", "tsx"];
          if (isEnabledForJavascript()) {
            syntaxes.push("javascript", "jsx");

Based on my interpretation of the LSP spec, the server is primarily in charge of indexing behavior. I’d expect it should be based on proper capability registration and notifications for the DidCreateFile notification.

mike.bronner · May 6, 2021, 6:02pm

I would agree with that assumption. However, it seems that Nova may not be implementing the registration capabilities fully, as commented on by Logan: LSP import action error - #2 by logan