Bug with textDocument/completion

triggerCharacter in textDocument/completion should only be set to known trigger characters that the server sets in initialize result under completionProvider.triggerCharacters. It seems Nova is sending the last character that the user typed.

I’ve been trying to hook up Nova and Deno and got stuck when the completion request Nova sends crashes the Deno LanguageServer and I filled this issue:


Hi, I’d really like to get the Deno LSP working. Is there more information about this @logan or anything I can do to help? At the moment every letter you type crashes the server so I can’t do much.

To add something buried a little that issue, it seems at least the Deno LSP expects the type of SignatureHelpTriggerKind to be ContentChange rather than TriggerCharacter to send the appropriate response back the client.