apexskier
October 29, 2020, 8:22am
1
I maintain the DefinitelyTyped nova types, I’d appreciate it if someone could look at and review the PR to update types for Nova 2.
DefinitelyTyped:master ← apexskier:nova-2
opened 08:03PM - 23 Oct 20 UTC
The biggest feature here is new dynamic Tasks and some language client improveme… nts
- [x] Use a meaningful title for the pull request. Include the name of the package modified.
- [x] Test the change in your own code. (Compile and run.)
- [x] Add or edit tests to reflect the change. (Run with `npm test YOUR_PACKAGE_NAME`.)
- [x] Follow the advice from the [readme](https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/README.md#make-a-pull-request).
- [x] Avoid [common mistakes](https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/README.md#common-mistakes).
- [x] Run `npm run lint package-name` (or `tsc` if no `tslint.json` is present).
- [x] Provide a URL to documentation or source code which provides context for the suggested changes: https://library.panic.com/releasenotes/nova/#2
- [x] If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.
- [x] Include [tests for your changes](https://github.com/DefinitelyTyped/DefinitelyTyped#testing)
- ~If you are making substantial changes, consider adding a `tslint.json` containing `{ "extends": "dtslint/dt.json" }`. If for reason the any rule need to be disabled, disable it for that line using `// tslint:disable-next-line [ruleName]` and not for whole package so that the need for disabling can be reviewed.~
logan
October 29, 2020, 5:41pm
2
I’ll take a look, Cameron! Thanks for keeping this up to date!
jsorge
January 13, 2023, 8:12pm
3
I’m very much new to JavaScript/TypeScript and developing Nova extensions. What’s the process for bringing these definitions in to an extension project? Do I need a package.json to do that? Thanks for putting the work into building these!