TreeView reloading

apexskier · November 6, 2020, 7:13pm

I’m having a bit of trouble with TreeView reloading. I want to reload a known, specific element, but I don’t have access to the original object to pass into treeView.reload. It appears that Nova relies on reference equality, so passing a newly made object doesn’t reload at all.

If it is a reference equality issue, I think I’d need a way to inform the tree view about a key or unique ID that it could use to compare elements. Maybe something like adding an optional getKey(element) method to TreeDataProvider that Nova uses to determine if an element is the same as another.

More context here…

github.com

apexskier/nova-jest/blob/e6a50bbd1d39585c36a58778a997ec8d872a856e/src/testResults.ts#L145-L153


      
          // TODO: I haven't yet figured out a reliable way to reload a specific element,
          // avoiding reference equality issues, that avoids spamming multiple reloads,
          // which causes annoying flickering issues
          // a simple mechanism would be a debounce, but there's some mores stuff to try.
          // eslint-disable-next-line no-unused-vars
          private _reloadTree(key: TestTreeElement | null) {
            // console.log("reload", key?.segments.join(":"));
            this._treeView.reload(null);
          }

jason · November 11, 2020, 8:12pm

Hi @apexskier. Have you made any progress on this? I’m not sure I can be of much immediate help, but I am curious.

apexskier · November 13, 2020, 11:37am

Nope, I haven’t found anything better than reloading the full tree.

jason · May 22, 2021, 5:54pm

Hi @apexskier. I was reminded of this post after I just posted another question asking something similar.

Did you figure out how to do this?

apexskier · May 23, 2021, 8:09am

Nope, no updates unfortunately. I still think an API change with stronger support for tree view keys is needed.

logan · May 27, 2021, 4:27pm

This definitely makes sense. TreeView does indeed use reference equality / === for comparing elements in the tree. I will mark this down as a feature request for the API.

jason · May 27, 2021, 8:37pm

Thanks for clarifying @logan!